Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bee7844. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Large new formatter surface area and a behavioral change to glob vs named import resolution; risk is mitigated by extensive formatter tests and CI formatting checks rather than security-critical paths.
Overview
Introduces a new
rue-formattercrate (0.10.0 workspace bump) that canonicalizes Rue source via the typed AST and rowan token stream, with rustfmt-like defaults, import/path reordering, comment ownership checks, and idempotent output verified by reparse.CLI & tooling:
rue fmtaccepts paths/globs and--check, resolvesFormatOptionsfromRue.toml([formatter]/max_width,indent_width). CI adds a Rue fmt step on examples, tests, and std.ruefiles.rue-testscan fail or update when the formatting corpus drifts.LSP: document formatting returns a full-file
TextEditusing the sameformat_sourcepath.Supporting changes:
AstNodeKindin rue-ast (exhaustive node kinds + tests);binary_binding_poweron parserSyntaxKind; import resolution sorts imports and skips glob symbols when a named import in the same scope already targets that name; std sources and a few compiler.ruefiles are reformatted to match the new style.Reviewed by Cursor Bugbot for commit 02f7ba2. Bugbot is set up for automated code reviews on this repo. Configure here.